Skip to content

CMR-11488 - Snyk - ORG JSOUP - #2491

Merged
jaortega527 merged 1 commit into
masterfrom
CMR-11488
Sep 2, 2026
Merged

CMR-11488 - Snyk - ORG JSOUP#2491
jaortega527 merged 1 commit into
masterfrom
CMR-11488

Conversation

@jaortega527

@jaortega527 jaortega527 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Overview

Address the Snyk vulnerability associated with org.jsoup:jsoup 1.14.2

Please summarize the reason for the changes made in this PR.

What are the changes?

  • Upgrade the explicit jsoup dependency in system-int-test from 1.14.2 to 1.23.2
  • Adds a direct jsoup dependency to common-app-lib to override the jsoup 1.14.3 transitive dependency brought in by flexmark-all

What areas of the application does this impact?

  • system-int-test
  • common-app-lib

NOTE: No application behavior is impacted. The direct dependency impacts system integration tests and the common-app-lib impacts a component of flexmark-all that CMR does not currently use

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

Additional Checklist

  • I have removed unnecessary/dead code and imports in files I have changed
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@codecov-commenter

codecov-commenter commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.19%. Comparing base (83b021c) to head (ec8d832).

❗ There is a different number of reports uploaded between BASE (83b021c) and HEAD (ec8d832). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (83b021c) HEAD (ec8d832)
12 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2491       +/-   ##
===========================================
- Coverage   57.96%   29.19%   -28.77%     
===========================================
  Files        1074     1014       -60     
  Lines       74707    71257     -3450     
  Branches     2194     1266      -928     
===========================================
- Hits        43304    20804    -22500     
- Misses      29354    49250    +19896     
+ Partials     2049     1203      -846     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…transitive dependency on org.jsoup:jsoup from 1.14.2 to 1.23.2
@jaortega527
jaortega527 merged commit 62070d1 into master Sep 2, 2026
6 checks passed
@jaortega527
jaortega527 deleted the CMR-11488 branch September 2, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants